demo: add test fixtures showing type-name quoting bug (DO NOT MERGE)#249
Closed
pyramation wants to merge 1 commit intomainfrom
Closed
demo: add test fixtures showing type-name quoting bug (DO NOT MERGE)#249pyramation wants to merge 1 commit intomainfrom
pyramation wants to merge 1 commit intomainfrom
Conversation
This PR demonstrates the bug where user-defined schema-qualified types with keyword names are over-quoted. The snapshots show: - myschema."json" (should be myschema.json) - custom."int" (should be custom.int) - myapp."boolean" (should be myapp.boolean) See PR #248 for the fix.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demo: add test fixtures showing type-name quoting bug (DO NOT MERGE)
Summary
This PR demonstrates the type-name quoting bug where user-defined schema-qualified types with keyword names are over-quoted. This PR should NOT be merged - it exists only to show the broken behavior before the fix.
The snapshots capture the buggy output:
myschema."json"(should bemyschema.json)custom."int"(should becustom.int)myapp."boolean"(should bemyapp.boolean)See PR #248 for the actual fix that corrects this behavior.
Review & Testing Checklist for Human
myschema."json"instead ofmyschema.json)Notes
This PR was created to demonstrate the bug before the fix, as requested by the reviewer.
Link to Devin run: https://app.devin.ai/sessions/713c834a5761453297e17345e1c1fd47
Requested by: Dan Lynch (@pyramation)